Correctly process large HTTP responses in network profiler #2602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The network profiler was assuming that a response body would only ever consist of a single chunk. This was resulting in us trying to decode a partial response, causing a FormatException to be thrown and halting processing of HTTP events. This change stitches together all of the response body events for a given response before trying to decode it. In addition, the FormatException is caught and ignored in order to allow for non-UTF8 responses. Fixes both #2398 and #2480
| try { | ||
| responseBody = utf8.decode(encodedData); | ||
| } on FormatException { | ||
| // Non-UTF8 response. |
Member
There was a problem hiding this comment.
Should we do something to handle non UTF8 responses so that the user has some indication that we did receive a response? What is an example of a non-utf8 response?
Contributor
Author
There was a problem hiding this comment.
An image is an example of a non-UTF8 response. If we try and decode that, it's certain to blow up.
kenzieschmoll
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network profiler was assuming that a response body would only ever
consist of a single chunk. This was resulting in us trying to decode a
partial response, causing a FormatException to be thrown and halting
processing of HTTP events.
This change stitches together all of the response body events for a
given response before trying to decode it. In addition, the
FormatException is caught and ignored in order to allow for non-UTF8
responses.
Fixes both #2398 and #2480